Issues using array.delete within a loop of the same array

ruby-talk
1

This is a simplified example for what I'm trying to do but gets the
point across:

irb(main):001:0> a = [1,2,3,4,5]
=> [1, 2, 3, 4, 5]
irb(main):002:0> a.each {|e| a.delete e}
=> [2, 4]

I would expect the array to be emptied. Insight please...

Yes, I know that there are other ways to empty an array (i.e. a =
[]). My code is more complex and I'm more interested in why this is
happening and if there is a work-around for removing array items while
iterating over the same array. There will be other cases in this code
where I will only want to remove some of the items.

Thanks in advance...

2

Use #delete_if instead.

···

james.d.masters@gmail.com wrote:

This is a simplified example for what I'm trying to do but gets the
point across:

irb(main):001:0> a = [1,2,3,4,5]
=> [1, 2, 3, 4, 5]
irb(main):002:0> a.each {|e| a.delete e}
=> [2, 4]

I would expect the array to be emptied. Insight please...

Yes, I know that there are other ways to empty an array (i.e. a =
). My code is more complex and I'm more interested in why this is
happening and if there is a work-around for removing array items while
iterating over the same array. There will be other cases in this code
where I will only want to remove some of the items.

Thanks in advance...

3

Yes, I know that there are other ways to empty an array (i.e. a =
).

a = creates a new, empty array; it does not empty the existing array.

My code is more complex and I'm more interested in why this is
happening

It's disallowed by design -- removing elements in the midst of iteration would be a bit like trying to remove carpet tiles while you are standing on them.

and if there is a work-around for removing array items while
iterating over the same array.

Have you considered using Array#reject! to iterate over the array? You can use the result of the block for each iteration (true or false) to control whether each element is dropped or retained once the iteration completes.

a.reject! { |e|
   # ... do stuff
   e > 3 # discard elements greater than three
}

-mental

···

On Sat, 17 Mar 2007 05:45:05 +0900, james.d.masters@gmail.com wrote:

4

Now this is pure speculation on my part and I'm not offering a solution to
the problem, rather a likely explanation. The other solutions all look good
to me as alternatives.

It would make sense that what Array#each is doing behind the scenes is
simply using an index and a for loop up to the size of the array, and then
passing you a[i]. So then during the first step you delete a[0], which
renumbers the elements in the array. During the second step you delete a[1],
which is now actually 3, since that's now the second element in the array.
Continue in this manner you'll skip every other element in the array.

···

On 3/16/07, james.d.masters@gmail.com <james.d.masters@gmail.com> wrote:

This is a simplified example for what I'm trying to do but gets the
point across:

irb(main):001:0> a = [1,2,3,4,5]
=> [1, 2, 3, 4, 5]
irb(main):002:0> a.each {|e| a.delete e}
=> [2, 4]

I would expect the array to be emptied. Insight please...

Yes, I know that there are other ways to empty an array (i.e. a =
). My code is more complex and I'm more interested in why this is
happening and if there is a work-around for removing array items while
iterating over the same array. There will be other cases in this code
where I will only want to remove some of the items.

Thanks in advance...

5

a = [1,2,3,4,5]
(a.length-1).downto(0){ |i|
  a.delete_at( i )
}
p a
#=>

···

On Mar 16, 2:42 pm, james.d.mast...@gmail.com wrote:

This is a simplified example for what I'm trying to do but gets the
point across:

irb(main):001:0> a = [1,2,3,4,5]
=> [1, 2, 3, 4, 5]
irb(main):002:0> a.each {|e| a.delete e}
=> [2, 4]

6

Thanks - I tried that and it also did not work. Sorry for not posting
this attempt in my original:

irb(main):001:0> a = [1,2,3,4,5]
=> [1, 2, 3, 4, 5]
irb(main):002:0> a.each {|e| a.delete_if {|e2| e2 == e}}
=> [2, 4]

···

On Mar 16, 2:01 pm, Timothy Hunter <TimHun...@nc.rr.com> wrote:

Use #delete_if instead.

7

a = creates a new, empty array; it does not empty the existing array.

Yup, good point.

It's disallowed by design -- removing elements in the midst of iteration would be a bit like trying to remove carpet tiles while you are standing on them.

OK, I'll take that... I had a feeling that would be the final answer.
Although I can't see why it wouldn't be feasible in a language -
especially as I'm removing the current item of iteration (i.e. not one
further down the list) and when there are no duplicates of the same
object in the array.

Have you considered using Array#reject! to iterate over the array? You can use the result of the block for each iteration (true or false) to control whether each element is dropped or retained once the iteration completes.

I vaguely remember reading about Array#reject! but haven't used it
much - I'll have to give that a shot. Thanks...

···

On Mar 16, 2:02 pm, MenTaLguY <men...@rydia.net> wrote:

8

Now this is pure speculation on my part and I'm not offering a solution to
the problem, rather a likely explanation. The other solutions all look good
to me as alternatives.

It would make sense that what Array#each is doing behind the scenes is
simply using an index and a for loop up to the size of the array, and then
passing you a[i]. So then during the first step you delete a[0], which
renumbers the elements in the array. During the second step you delete a[1],
which is now actually 3, since that's now the second element in the array.
Continue in this manner you'll skip every other element in the array.

Let us see

VALUE
rb_ary_each(ary)
    VALUE ary;
{
    long i;

    for (i=0; i<RARRAY(ary)->len; i++) {
        rb_yield(RARRAY(ary)->ptr[i]);
    }
    return ary;
}

your speculation was correct :slight_smile: fortuntely i < RARRAY(ary)-> len is
reavaluated after each yield!

Cheers
Robert

<snip>

···

On 3/16/07, Fedor Labounko <fedor.labounko@gmail.com> wrote:

--
You see things; and you say Why?
But I dream things that never were; and I say Why not?
-- George Bernard Shaw

9

Maybe better to say that the behavior is implementation
dependent and therefore should be avoided.

The word "disallow" implies that it is syntactically
invalid or that it will raise an exception yet, as was
shown by other posters, neither occurs.

Gary Wright

···

On Mar 16, 2007, at 5:02 PM, MenTaLguY wrote:

It's disallowed by design -- removing elements in the midst of iteration would be a bit like trying to remove carpet tiles while you are standing on them.

10

Kindly suggest that you RTFM by typing "ri Array#delete_if" into your
console. :slight_smile:

If that doesn't make it clear, try this:

a.delete_if{ true }

···

On Mar 16, 4:00 pm, james.d.mast...@gmail.com wrote:

On Mar 16, 2:01 pm, Timothy Hunter <TimHun...@nc.rr.com> wrote:

> Use #delete_if instead.

Thanks - I tried that and it also did not work. Sorry for not posting
this attempt in my original:

irb(main):001:0> a = [1,2,3,4,5]
=> [1, 2, 3, 4, 5]
irb(main):002:0> a.each {|e| a.delete_if {|e2| e2 == e}}
=> [2, 4]

11

#delete_if itself iterates over the array elements. You don't need to use #each at all.

$ irb
irb(main):001:0> a = [0,1,2,3,4,5]
=> [0, 1, 2, 3, 4, 5]
irb(main):002:0> a.delete_if {|e| e %2 == 0}
=> [1, 3, 5]
irb(main):003:0>

···

james.d.masters@gmail.com wrote:

On Mar 16, 2:01 pm, Timothy Hunter <TimHun...@nc.rr.com> wrote:
  

Use #delete_if instead.
    
Thanks - I tried that and it also did not work. Sorry for not posting
this attempt in my original:

irb(main):001:0> a = [1,2,3,4,5]
=> [1, 2, 3, 4, 5]
irb(main):002:0> a.each {|e| a.delete_if {|e2| e2 == e}}
=> [2, 4]

12

>
> > Use #delete_if instead.
>
> Thanks - I tried that and it also did not work. Sorry for not posting
> this attempt in my original:
>
> irb(main):001:0> a = [1,2,3,4,5]
> => [1, 2, 3, 4, 5]
> irb(main):002:0> a.each {|e| a.delete_if {|e2| e2 == e}}
> => [2, 4]

Kindly suggest that you RTFM by typing "ri Array#delete_if" into your
console. :slight_smile:

If that doesn't make it clear, try this:

a.delete_if{ true }

This is a nice alias for a.clear :wink:
Robert

···

On 3/16/07, Phrogz <gavin@refinery.com> wrote:

On Mar 16, 4:00 pm, james.d.mast...@gmail.com wrote:
> On Mar 16, 2:01 pm, Timothy Hunter <TimHun...@nc.rr.com> wrote:

--
You see things; and you say Why?
But I dream things that never were; and I say Why not?
-- George Bernard Shaw

13

I did RTFM before posting. The question in my original posting was
related to the behavior of deleting items from a list during iteration
so that's why I posted Array#delete_if within the context of
Array#each. To use Array#delete_if outside of the iteration does the
job yet the original question remained. I think that the answer is
that deleting from the same array during an iteration is a no-no using
Array#each... I'm OK with that. I'll use Array#delete_if or
Array.reject!

Thanks...

···

On Mar 16, 3:08 pm, "Phrogz" <g...@refinery.com> wrote:

Kindly suggest that you RTFM by typing "ri Array#delete_if" into your
console. :slight_smile:

14

> Kindly suggest that you RTFM by typing "ri Array#delete_if" into your
> console. :slight_smile:

I did RTFM before posting. The question in my original posting was
related to the behavior of deleting items from a list during iteration
so that's why I posted Array#delete_if within the context of
Array#each. To use Array#delete_if outside of the iteration does the
job yet the original question remained. I think that the answer is
that deleting from the same array during an iteration is a no-no using
Array#each... I'm OK with that. I'll use Array#delete_if or
Array.reject!

Thanks...

The code I posted was version 1.8.5 p12, and of course I should have
added that the behavior is not defined.
YARV does exactly the same right now though.

Good to point it out clearly.

Cheers
Robert

···

On 3/16/07, james.d.masters@gmail.com <james.d.masters@gmail.com> wrote:

On Mar 16, 3:08 pm, "Phrogz" <g...@refinery.com> wrote:

--
You see things; and you say Why?
But I dream things that never were; and I say Why not?
-- George Bernard Shaw