Grade my test?

ruby-talk
1

I have directory of data files along with a few other types of files. The
data file names start at 0000 and run to 3999. I have a program that
creates an array for the data files without the non data files. This
program works good but have I created the shortest way of doing the task?
Thanks for grading my test. Jeff

#Puts the contents of the current directory into data_files.
dir_file_list = Dir.entries(".")
data_files = []

dir_file_list.each do|files|
  if files.to_i > 0 && files.to_i < 4000
    data_files.push files
  end
end

puts data_files

···

–
View this message in context: http://www.nabble.com/Grade-my-test--tf3931596.html#a11151192
Sent from the ruby-talk mailing list archive at Nabble.com.

2

That would work just fine. Here's another one:

data_files = Dir.entries.select { |file| (1...4000).include? file.to_i }

Be aware of how #to_i works, though. This will grab a file named
"24-7Project", for example.

Todd

···

On 6/16/07, jabowen <ja_bowen@yahoo.com> wrote:

I have directory of data files along with a few other types of files. The
data file names start at 0000 and run to 3999. I have a program that
creates an array for the data files without the non data files. This
program works good but have I created the shortest way of doing the task?
Thanks for grading my test. Jeff

#Puts the contents of the current directory into data_files.
dir_file_list = Dir.entries(".")
data_files = []

dir_file_list.each do|files|
        if files.to_i > 0 && files.to_i < 4000
                data_files.push files
        end
end

puts data_files

3

Does it really work? What about file "0000' ?
The problem is that "a".to_i --> 0
I would go for

   Dir["[0-9]"*4]

or
   Dir["[0-3]" + "[0-9]"*3]
if necessary.

HTH
Robert

···

On 6/16/07, jabowen <ja_bowen@yahoo.com> wrote:

I have directory of data files along with a few other types of files. The
data file names start at 0000 and run to 3999. I have a program that
creates an array for the data files without the non data files. This
program works good but have I created the shortest way of doing the task?
Thanks for grading my test. Jeff

#Puts the contents of the current directory into data_files.
dir_file_list = Dir.entries(".")
data_files = []

   >

dir_file_list.each do|files|
        if files.to_i > 0 && files.to_i < 4000
                data_files.push files
        end
end

puts data_files

--
You see things; and you say Why?
But I dream things that never were; and I say Why not?
-- George Bernard Shaw