Bug in Net::HTTP

ruby-talk
1

Net::HTTP will crash if the remote HTTP server returns a Content-Range
header without a Content-Length header. I have attached a program that
will reproduce the bug. The program has a self-contained dummy HTTP
server that listens on localhost 12345. It then connects to that
server using Net::HTTP, which feeds Net::HTTP a response containing a
Content-Range header without a Content-Length header, causing it to
crash due to the bug.

Here are the error messages I get:

Under ruby 1.6.8 (2002-12-24) [i686-linux]:
/usr/local/lib/ruby/1.6/net/protocol.rb:614:in `sysread’: End of file
reached (EOFError)

Under ruby 1.8.0 (2003-05-26) [i386-mswin32]:
c:/ruby/lib/ruby/1.8/net/http.rb:1147:in range_length': undefined method length’ for 1…11:Range (NoMethodError)

bug.rb (560 Bytes)

2

Hello,

Net::HTTP will crash if the remote HTTP server returns a Content-Range
header without a Content-Length header. I have attached a program that
will reproduce the bug. The program has a self-contained dummy HTTP
server that listens on localhost 12345. It then connects to that
server using Net::HTTP, which feeds Net::HTTP a response containing a
Content-Range header without a Content-Length header, causing it to
crash due to the bug.

The following patch seems to work. It still need to be confirmed by
the maintainer.

						matz.

— lib/net/http.rb 2 Jul 2003 02:05:35 -0000 1.86
+++ lib/net/http.rb 27 Jul 2003 14:33:12 -0000
@@ -1146,3 +1146,3 @@ module Net
r = self.content_range

  •  r and r.length

  •  r and r.end - r.begin
    end
···

In message “Bug in Net::HTTP” on 03/07/27, Philip Mak pmak@aaanime.net writes: