Escaping Attributes with Builder::XmlMarkup

Just hit a problem using FeedTools where links with ampersands in them
were being left unescaped in the output. I realised this was a
Builder::XmlMarkup thing, and patched it there, but when I went to the
Builder::XmlMarkup CVS to see what was going on there, I found this:

http://rubyforge.org/cgi-bin/viewcvs.cgi/builder/lib/builder/xmlmarkup.r
b.diff?r1=1.3&r2=1.4&cvsroot=builder

It seems that a new option has already been added to Builder::XmlMarkup
to escape XML attributes, but that it defaults to false. Is there a
reason for this? I was sure that <element attr="value&value"> was not
well-formed XML, and should read <element attr="value&amp;value"> - why
is that not the default behaviour?

So, which library needs to be fixed? Builder or FeedTools?

(BTW - this is affecting the xml reprocessing in the CVS version of
MouseHole - so _why you might want to keep an eye on this).

ยทยทยท

#####################################################################################
This email has been scanned by MailMarshal, an email content filter.
#####################################################################################